Hate to bump up a page-2 topic, but I've got a lot of catch up reading/posting to do and this one seemed like a nice quasi-old topic to contribute to. Anyway...
10.
Reefer Madness (2005) - this is the third incarnation of the musical (there's a 1998 LA version and a 2001 Off-Broadway version), and has a few minor changes but otherwise is the same. It's a rather hyperactive and obnoxiously funny take on the original propoganda film, with excellent performances by Alan Cumming, Christian Campbell, Kristen Bell, and the rest of the cast. My favorite songs from it are "Mary Jane/Mary Lane" (which was written for the TV version), "Romeo and Juliet", the S&M-themed "Little Mary Sunshine", and "The Brownie Song".
9.
Swing Time (1936) - this is the sixth of Fred & Ginger's ten films they did together and many call it their best. I definitely agree with that sentiment as it's got such memorable numbers and songs, with "A Fine Romance" and "Never Gonna Dance" being the best. I enjoy their other nine films, but
Swing Time has gotten the most replay from me.
8.
Newsies (1992) - where else can you find Christian Bale dancing?

I enjoy this one mainly for the songs and dances rather than the story and acting. "King of New York" is probably my favorite song, with "Carrying the Banner" being the best dance number. I haven't watched this in a few months, I'll probably give it a spin later this week.
7.
The Sound of Music (1965) - I've seen this film on an old pan-and-scan VHS more times in my childhood than anyone ever should, and usually if/when I watch it now, it's kind of jarring to see it in its widescreen splendour. But it's still a favorite of mine, as a kid I really loved "My Favorite Things", but I think today my favorite song is "Something Good" (it's the romantic in me).
6.
It's Always Fair Weather (1955) - singing while on roller skates. "Blue Danube" set to depressing lyrics. The delightfully imaginative "Thanks A Lot, But No Thanks". And Cyd Charisse dancing with boxers. Seriously, how can anyone NOT love this?
5.
Across the Universe (2007) - I only just saw this a month ago, so its "recentness" is probably a factor in why it's on the list as opposed to films like
Oklahoma! or
Guys & Dolls (both of which I enjoy, but not in the top 10 sense). But either way, I was simply floored by every aspect of it. It would be an insult to
Across the Universe to call it a mere movie. It's an enlightening experience, a visual orgasm.
4.
Seven Brides for Seven Brothers (1954) - I still remember when I first saw this on Turner Classic, and after Robert Osborne's introduction, I just thought, "How the HELL can they make this kind of story into a musical?!?" Thankfully, they proved they could and it's become a real favorite with "Lonesome Polecat" (all done in one long take!) and "Bless Your Beautiful Hide" being my favorite songs.
3.
Mary Poppins (1964) - perhaps my favorite Disney movie ever, at least in the live-action category. This is another that I watched frequently in my childhood, I always loved "A Spoonful of Sugar" (which actually taught me how to snap my fingers!) and "Step in Time (which was probably why I was skinny as a kid). These days, the film gets probably one viewing every couple months, and is one of the few where I can watch it and still believe it's *real* and not a movie.
2.
Singin' in the Rain (1952) - I almost didn't put it on the list because it's become too much of a stock answer that its placement would seem like a cop-out to fill up the list. But the more I thought about it, the more I remembered how much I loved it and I don't care if it seems like a stock answer or not. I really love the entire Broadway Ballet, but I think my favorite part of the movie isn't even a song/dance: it's the part when Don first jumps into Kathy's car and she gets completely petrified that he's a gangster or a killer of some sort.
1.
The Band Wagon (1953) - it's got a very basic story that takes like...ten words to explain: "People put together a show despite the leads always clashing". It's been done in other films before and after, and is pretty standard. But this musical ranks as my favorite for a lot of reasons beyond the story (which, even if standard, has some cool variances to it). It's got one of the best pairings the screen has ever seen (Fred Astaire & Cyd Charisse), some of the best numbers ever done ("Dancing in the Dark" especially, I've always said it's one of the most sensual dance numbers ever put to celluloid), and a wide selection of instantly hummable songs ("That's Entertainment!", "By Myself", the unused "Two-Faced Woman"). I really can't think of that much to write for this, mainly because I love everything about it that mere words couldn't explain it all.
Albert